Skip to content

[ReduceFnRunner] Fix Prefetches - #39082

Merged
scwhittle merged 1 commit into
apache:masterfrom
arunpandianp:fix_prefetch
Jun 24, 2026
Merged

[ReduceFnRunner] Fix Prefetches#39082
scwhittle merged 1 commit into
apache:masterfrom
arunpandianp:fix_prefetch

Conversation

@arunpandianp

Copy link
Copy Markdown
Contributor
  1. Add a prefetch for CombinedMetadata
  2. Prefetch ReduceFn using renamedContext instead of directContext. This improves prefetching on merging windows

1. Add a prefetch for CombinedMetadata
2. Prefetch ReduceFn using renamedContext instead of directContext. This
   improves prefetching on merging windows
@arunpandianp

Copy link
Copy Markdown
Contributor Author

R: @scwhittle

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the prefetching strategy within the ReduceFnRunner to reduce latency during window merging. By refining the context used for state access and ensuring necessary metadata is prefetched, the runner can handle state operations more efficiently.

Highlights

  • CombinedMetadata Prefetching: Added a new prefetch operation for CombinedMetadata to improve data access efficiency during trigger execution.
  • Context Optimization: Updated the ReduceFn prefetch call to use renamedContext instead of directContext, enhancing performance for merging windows.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the prefetchOnTrigger method in ReduceFnRunner.java to prefetch the metadata tag from the direct context state and switches the reduceFn.prefetchOnTrigger call to use the renamed context state instead of the direct context state. There are no review comments to address, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@arunpandianp

Copy link
Copy Markdown
Contributor Author

cc: @stankiewicz

@scwhittle
scwhittle merged commit cedfd0b into apache:master Jun 24, 2026
24 checks passed
ash6898 pushed a commit to ash6898/beam that referenced this pull request Jun 28, 2026
1. Add a prefetch for CombinedMetadata
2. Prefetch ReduceFn using renamedContext instead of directContext. This improves prefetching on merging windows
ash6898 pushed a commit to ash6898/beam that referenced this pull request Jun 29, 2026
1. Add a prefetch for CombinedMetadata
2. Prefetch ReduceFn using renamedContext instead of directContext. This improves prefetching on merging windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants